search

eu-digital-identity-wallet / eudi-doc-architecture-and-reference-framework

The European Digital Identity Wallet
https://eu-digital-identity-wallet.github.io/eudi-doc-architecture-and-reference-framework/
Other
369 stars 55 forks source link

Minor ortography fixes #134

Open joelposti opened 3 months ago

joelposti commented 3 months ago

Minor ortography fixes for the ARF and the annexes. Fixes are split into multiple commits and each commit has an explanatory comment.

One of the changes is in docs/media/image7.svg (replaced ‘EUDI Wallet instance’ with ‘EUDI Wallet Instance’). It looks like the related file docs/media/image7.png already has the latter ortography and thus no changes for that file is needed.

joelposti commented 3 months ago

I pushed some additional orthography fixes. Should I create a new pull request or keep the commits in this one?

One of the added fixes is in docs/media/image1.svg (capitalised solution in ‘Wallet Solution’). This fix should be done in the related file docs/media/image1.png, too.

skounis commented 3 months ago

Process wise the review already started so new commits will make it more difficult. On top of this the PR has already approved by two reviewers before the new commits.

However I checked the commits one by one and my positive vote remains unchanged ;-)

joelposti commented 3 months ago

Okay, thank you for your patience. I am sorry that I deviated from the process. I should have asked first before pushing new commits.

pinamiranda commented 4 days ago

Thank you for submitting the Pull Request.

We have reviewed ARF 1.4, and all the minor ortography issues have been fixed (or will be fixed in ARF 1.4.1)