eu-digital-identity-wallet / eudi-lib-ios-openid4vci-swift

Implementation of OpenID for Verifiable Credential Issuance protocol (wallet's role) in Swift
Apache License 2.0
4 stars 5 forks source link

credential offer resolve problem #44

Closed cindy-chin closed 2 weeks ago

cindy-chin commented 1 month ago

Hi, recently I was trying out the new QR code scanning, and I notice if the QR code contain only credential_offer_uri, it is working find, but when the QR code contain credential offer object, it turns out to have some issue.

this is the example of after the wallet do removingPercentEncoding, it seems strange for me. seems like some json decoding should be done.

eudi-openid4vci://?credential_offer={\"credential_issuer\":\" https://a3bb-116-14-111-226.ngrok-free.app\",\"credential_configuration_ids\":[\"eu.europa.ec.eudiw.pid_mso_mdoc\"],\"grants\":{\"authorization_code\":{\"authorization_server\":\"https://f17d-116-14-111-226.ngrok-free.app/idp/realms/pid-issuer-realm\"}}}"

Thank You

stzouvaras commented 1 month ago

Hi @cindy-chin ,

Thank you for your feedback. We are reviewing it and will get back to you soon.

dtsiflit commented 2 weeks ago

Transfering this over to https://github.com/eu-digital-identity-wallet/eudi-lib-ios-openid4vci-swift

dtsiflit commented 2 weeks ago

This issue is now fix in https://github.com/eu-digital-identity-wallet/eudi-lib-ios-openid4vci-swift/releases/tag/v0.1.5