eu-digital-identity-wallet / eudi-lib-ios-openid4vci-swift

Implementation of OpenID for Verifiable Credential Issuance protocol (wallet's role) in Swift
Apache License 2.0
6 stars 7 forks source link

Fix Bearer authorization token spelling #51

Closed srosenda closed 1 month ago

srosenda commented 1 month ago

Description of change

The bearer prefix for the token should be spelled excactly as "Bearer", see https://datatracker.ietf.org/doc/html/rfc6750#section-2.1. The misspelled token was rejected by the Finnish EUDIWallet backend.

Fixes #52.

Implementation notes

Use TokenType.rawValue to produce string value of the token prefix to have the correct values defined in a single place.

Type of change

How Has This Been Tested?

Checklist:

dtsiflit commented 1 month ago

Thank you for the PR @srosenda! We'll look at it over the next few days.

srosenda commented 1 month ago

Thank you for the PR @srosenda! We'll look at it over the next few days.

You're welcome! FYI: I and most others in my team will be on vacation until beginning of August, so our replies to any feedback will take until there.

dtsiflit commented 1 month ago

Thank you for the PR @srosenda! We'll look at it over the next few days.

You're welcome! FYI: I and most others in my team will be on vacation until beginning of August, so our replies to any feedback will take until there.

Same here :) I will look into this

Thank you for the PR @srosenda! We'll look at it over the next few days.

You're welcome! FYI: I and most others in my team will be on vacation until beginning of August, so our replies to any feedback will take until there.

No worries, same here :)