eu-digital-identity-wallet / eudi-lib-jvm-openid4vci-kt

Implementation of OpenID for Verifiable Credential Issuance protocol (wallet's role) in Kotlin
Apache License 2.0
18 stars 8 forks source link

Missing Cryptographic binding method `x5c` #140

Closed babisRoutis closed 7 months ago

babisRoutis commented 7 months ago

CryptographicBindingMethod should have an additional member

data object X5C: CryptographicBindingMethod {
        private fun readResolve(): Any = X5C

    }
babisRoutis commented 7 months ago

I am not sure that this is a bug.

Given the following description from spec

cryptographic_binding_methods_supported: OPTIONAL. Array of case sensitive strings that identify the representation of the cryptographic key material that the issued Credential is bound to, as defined in Section 7.1. Support for keys in JWK format [RFC7517] is indicated by the value jwk. Support for keys expressed as a COSE Key object [RFC8152] (for example, used in [ISO.18013-5]) is indicated by the value cose_key. When the Cryptographic Binding Method is a DID, valid values are a did: prefix followed by a method-name using a syntax as defined in Section 3.1 of [DID-Core], but without a :and method-specific-id. For example, support for the DID method with a method-name "example" would be represented by did:example.

it seems that valid values are:

There is no x5c