eu-digital-identity-wallet / eudi-lib-jvm-sdjwt-kt

A library for issuing and verifying SD-JWT
Apache License 2.0
14 stars 4 forks source link

Helper method for the parsing of a sdjwt string to retrieve claims #201

Closed goncalo-frade-iohk closed 1 week ago

goncalo-frade-iohk commented 1 month ago

Hey guys. How are you? I found this use case and I think it would be useful to add.

As a developer I may want to process an SDJWT without verifying.

Having a helper function that would initialise a holder SdJwt, would simplify this process. This way I could initialise a SdJWT without the need of having a suspended function.

This would be very useful when as a holder you want to process the claims of a saved SDJwt without the need of verifying it again. I understand there is JwtSignatureVerifier.Companion.NoSignatureValidation but it still requires to be suspended.

Closes #200

goncalo-frade-iohk commented 3 weeks ago

Hey @babisRoutis sorry I had some priority items to go through this week. Next week I will be able to finalize this changes.

babisRoutis commented 3 weeks ago

@goncalo-frade-iohk No worries. Please make sure to rebase main on your branch when you ready for review.

VHerasymov commented 1 week ago

@goncalo-frade-iohk @babisRoutis Hello guys, we're looking for an update with this PR since need this feature as well. If you need, we can offer a help

babisRoutis commented 1 week ago

@goncalo-frade-iohk , @VHerasymov I am closing this. Please follow https://github.com/eu-digital-identity-wallet/eudi-lib-jvm-sdjwt-kt/pull/212

babisRoutis commented 1 week ago

@goncalo-frade-iohk , @VHerasymov PR #212 has been merged and included in v0.5.1 Shortly, you would be able to get the new version from maven central.

goncalo-frade-iohk commented 1 week ago

@babisRoutis @VHerasymov was coming now to finally finalise this, and noticed it was merged. Sorry for the delay had a few crazy 2 weeks.

Not sure why I don't receive emails or notifications on new messages here.

And thank you @babisRoutis for finalising it 🚀