search

eu-digital-identity-wallet / eudi-lib-jvm-siop-openid4vp-kt

Implementation of SIOPv2 and OpenID4VP protocols (wallet's role) in Kotlin
Apache License 2.0
10 stars 2 forks source link

OpenID4VP draft 20 path formatting #210

Closed ivan770 closed 5 months ago

ivan770 commented 6 months ago

Hi!

While trying to use the web verifier app I noticed that it generates presentation requests according to the OpenID4VP draft 18, with paths formatted like so: $.mdoc.field.

Draft 20, which is linked in the project README file specifies that paths have to be formatted in a different manner, with namespace qualification: $[namespace][field].

vafeini commented 6 months ago

Hi @ivan770 ,

Current version of the library is not yet aligned with draft 20, it is still on draft 19 as stated in the README file. Regarding the link unfortunatelly there is no draft 19 page provided. There is for draft 18 and draft 20 but not for 19 :D so we selected to use the one for draft 20 and state on the readme that from this page only changes of draft 19 are implemented.

I understand though this might introduce some confusion so we will do our best to clear it up.

Also from the perspective of this library the contents of the presentation_definition are expected to comply to presentation exchange v2. This means that it is the Verifier's responsibility to provide the presentation definition.

Thus, we need to update the web verifier. There is an issue to track this

dzarras commented 5 months ago

@babisRoutis @vafeini Since this relates to eu-digital-identity-wallet/eudi-web-verifier#33, shouldn't we either close this issue or move it to eu-digital-identity-wallet/eudi-web-verifier for better tracking?

vafeini commented 5 months ago

@ivan770 Closing this one as the same is discussed here