eu-digital-identity-wallet / eudi-lib-jvm-siop-openid4vp-kt

Implementation of SIOPv2 and OpenID4VP protocols (wallet's role) in Kotlin
Apache License 2.0
10 stars 2 forks source link

Unable to serialize ResolvedRequestObject #217

Closed ydanneg closed 5 months ago

ydanneg commented 5 months ago

It is currently unable to serialize ResolvedRequestObject.

All models that are defined in here are Serializable. But PresentationDefinition is coming from another library eudi-lib-jvm-presentation-exchange-kt which is not Serializable.

The use case for serialization is simple:

Currently it is not possible.

Unit test: https://gist.github.com/ydanneg/3f24f7d0a1ec8eeb9511f968fc4b4c86

ydanneg commented 5 months ago

One approach would be to make all types defined here to be java.io.Serializable

babisRoutis commented 5 months ago

Hi @ydanneg

Yes, you are absolute right, both for the problem and for the solution. Opened https://github.com/eu-digital-identity-wallet/eudi-lib-jvm-presentation-exchange-kt/issues/137 to fix this in the presentation exchange library and then provide an update version for vp.

Thanks for this

vafeini commented 5 months ago

Hi @ydanneg, We have just released version v0.3.2 of the library with the fix implemented in v0.2.1. It should be reaching maven central soon.

Closing this one.

Thanks