eu-digital-identity-wallet / eudi-lib-sdjwt-swift

A library for issuing and verifying SD-JWT
Apache License 2.0
4 stars 6 forks source link

feat(jose): updated to use a new jose library #24

Closed goncalo-frade-iohk closed 4 months ago

goncalo-frade-iohk commented 5 months ago

Description of change

This commit updates the code base to use this jose library instead. Now it uses https://github.com/beatt83/jose-swift that has more features, it also supports JWT.

Type of change

How Has This Been Tested?

This change requires that all the Unit tests continue passing.

Checklist:

dtsiflit commented 5 months ago

Hello @goncalo-frade-iohk , I'm running the tests on this branch (fastlane tests) and I am getting the following errors within jose-swift:

jose-swift/Sources/JSONWebAlgorithms/KeyManagement/KeyEncryption/AES/AESKeyUnwrap+KeyUnwrap.swift:41:24: 'KeyWrap' is only available in iOS 15.0 or newer

jose-swift/Sources/JSONWebAlgorithms/KeyManagement/KeyEncryption/AES/AESKeyUnwrap+KeyUnwrap.swift:41:32: 'unwrap(_:using:)' is only available in iOS 15.0 or newer

Is there something else I should be doing? Thanks!

Edit: My bad, updating to the latest package versions (3.1.0) works perfectly

goncalo-frade-iohk commented 5 months ago

@dtsiflit Ive seen the CI was failing because of the swift tools as well. I updated the eudi-lib-sdjwt-swift package for swift tools for 5.8.1 and the minimum version of the jose-swift to 3.1.0 ;)

dtsiflit commented 4 months ago

Addresses #22

Great work @goncalo-frade-iohk many thanks!