eu-digital-identity-wallet / eudi-web-verifier

Apache License 2.0
8 stars 8 forks source link

Update PID Presentation Definition #33

Closed dzarras closed 5 months ago

dzarras commented 7 months ago

The PID Presentation Definition paths must be updated as per: https://openid.net/specs/openid-4-verifiable-presentations-1_0.html#name-presentation-request-4

Reference: https://github.com/eu-digital-identity-wallet/eudi-web-verifier/blob/main/src/app/core/data/pid_presentation_definition.ts

babisRoutis commented 6 months ago

This is part of OpenId4VP draft 20 & ISO-18013-7 profile. We need to implemented. Scheduled for v0.2.0 milestone

tlodderstedt commented 5 months ago

When can we expect the v0.2.0 milestone? I'm asking since people are getting confused about the presentation definition generated by the verifier not being compatible with 18013-07 nor OID4VP A.3.

babisRoutis commented 5 months ago

When can we expect the v0.2.0 milestone? I'm asking since people are getting confused about the presentation definition generated by the verifier not being compatible with 18013-07 nor OID4VP A.3.

Hi @tlodderstedt
Yes, that's clear.

Hopefully, next week

Sakurann commented 5 months ago

Just to clarify, for mdocs, can we expect presentation definition compliant with 18013-7, and for other credential formats, as defined in OID4VP Annex? Thank you!

babisRoutis commented 5 months ago

Just to clarify, for mdocs, can we expect presentation definition compliant with 18013-7, and for other credential formats, as defined in OID4VP Annex? Thank you!

Hi @Sakurann

We will use the 18013-7 conventions to form the PID presentation definition. (Should be referenced to Annex 3 of OpenId4VP?)

With regards to other credential formats, I guess that, we will have to wait for a new version of PID rulebook :smile:

PS:This repo contains contains just a web ui. The actual presentation process is being implemented by a programmable service (conceived initially as a testing tool for openid4vp) located here. So far, the primary focus of the test tool was on the interactions (JAR by ref, by value, client meta by ref, or by value, direct_post or direct_post.jwt etc).

babisRoutis commented 5 months ago

As a concrete example, we will use PD like this one.

babisRoutis commented 4 months ago

@tlodderstedt , @Sakurann FYI this has been hopefully fixed. https://verifier.eudiw.dev/