Probable performance issue in DbEncryptionService.java

[a-trzewik]

Describtion

DbEncryptionService use synchronize block for encryption.

private byte[] encrypt(byte[] plain) throws InvalidKeyException, BadPaddingException, IllegalBlockSizeException, InvalidAlgorithmParameterException { synchronized (cipher) { cipher.init(Cipher.ENCRYPT_MODE, key, getInitializationVector()); return cipher.doFinal(plain); } }

This limit the server to enrypt only one thing in the time. All other threads will block Because the encryption is done for many column fields in the time it will have inpact on data insert performance, which now can be done only in sequence

Expected behaviour

Do not block here

Possible Fix

Please create bunch on cipher(more or less depending on available processors) and reuse them in parallel. You may use ConcurrentLinkedDeque to hold the ciphers for it So take chiper from queue use it and put it back see https://www.baeldung.com/java-lifo-thread-safe Perhats there is already something in spring for it.