search

eu-nebulous / optimiser-controller

Mozilla Public License 2.0
0 stars 0 forks source link

Drop .gitreview #6

Closed yoctozepto closed 3 months ago

yoctozepto commented 3 months ago

This is obsolete and confusing on GitHub; was used with OpenDev's Gerrit.

rudi commented 3 months ago

@yoctozepto .gitreview is still on the r1 branch, unfortunately.

Could you write up the procedure to get a patch into both main and r1? That's something I'll need to do frequently, and I don't know a good way yet. Getting rid of .gitreview repo-wide is so trivial that it will make a good case study :) Many thanks!

yoctozepto commented 3 months ago

.gitreview is still on the r1 branch,

I'm aware.

unfortunately.

It's not that bad. It's not the development branch.

Could you write up the procedure to get a patch into both main and r1?

Sure thing.

That's something I'll need to do frequently,

This sounds wrong. Release branches should only receive bugfixes. When you say you'll do this frequently, I conclude you either want to backport features (not the goal) or assume there will be plenty of required bugfixes (that's sad)... ;-)

rudi commented 3 months ago

Thanks for the writeup! It's appreciated. Me developing on both branches is a special case for now -- Robert wants features like parallel deployment for r1, and these have to go on master as well.