euanwm / OpenWeightlifting

Repository that is deployed for the OpenWeightlifting site
https://www.openweightlifting.org
BSD 3-Clause "New" or "Revised" License
31 stars 21 forks source link

Update CONTRIBUTING.md #250

Closed Veerhan-glitch closed 11 months ago

Veerhan-glitch commented 11 months ago

This is with regards to issue #244

What has been done:

A proper guideline for contributing to the repo has been added

What hasn't been done:

Discord sever link is to be added on lines 26 and 72

If you need me to change/improve on anything please tell me

regards

p.s. sorry for the #249 pr, i did not meant to create it

euanwm commented 11 months ago

Can we add this in with regards to PR / fork naming:

Branches are named using the following convention:

feature/ for new feature implementations
fix/ for broken code / build / bug fixes
chore/ non-breaking & non-fixing code changes such as linting, formatting, etc.
Veerhan-glitch commented 11 months ago

I have made the changes pls review and revert

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (6165ea5) 91.11% compared to head (136c75c) 91.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #250 +/- ## ============================================ Coverage 91.11% 91.11% ============================================ Files 11 11 Lines 360 360 ============================================ Hits 328 328 Misses 25 25 Partials 7 7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.