euanwm / OpenWeightlifting

Repository that is deployed for the OpenWeightlifting site
https://www.openweightlifting.org
BSD 3-Clause "New" or "Revised" License
31 stars 21 forks source link

Add db checks for best snatch, best cj, and total #337

Closed joeysantia closed 2 months ago

joeysantia commented 2 months ago

Added conditionals to check_db.py to ensure that:

  1. Best snatch value is the greatest value of the snatch attempts or zero, whichever is greater
  2. Best cj value is the greatest value of the cj attempts or zero, whichever is greater
  3. Total is either the sum of the best snatch and cj values or zero if one of the best values is zero
euanwm commented 2 months ago

@joeysantia thanks for this, I'll get round to reviewing it tomorrow morning. It's flagged around 15k entries already so I need to investigate a few other things first.

euanwm commented 2 months ago

Closes #334

joeysantia commented 2 months ago

@euanwm definitely! thanks for tagging me in those other issues -- i'll check them out