search

euanwm / OpenWeightlifting

Repository that is deployed for the OpenWeightlifting site
https://www.openweightlifting.org
BSD 3-Clause "New" or "Revised" License
31 stars 21 forks source link

Norway scraper tool returns bad values #338

Closed euanwm closed 1 month ago

euanwm commented 2 months ago

Describe the bug When calculating the best scores, it is possible that a negative value is returned. This will when be deducted from the overall score when added to the total.

To Reproduce Steps to reproduce the behavior:

  1. Pull event ID 444 with the Norway scraping tool
  2. Check result by Ingeborg Endresen

Expected behavior A negative value implies a missed / not made lift and as result should be a zero value when being added to the total and should a lifter fail to a make a single lift during the session. The lowest value permissible in Best Snatch, Best C&J, and Best Total is ZERO.

Additional context You can also use the event ID with the Norwegian Weightlifting Federation's results system to compare against:

euanwm commented 2 months ago

@joeysantia - This is another easy one if you're interested in it.

joeysantia commented 2 months ago

@euanwm thanks, i'll check it out!