euanwm / OpenWeightlifting

Repository that is deployed for the OpenWeightlifting site
https://www.openweightlifting.org
BSD 3-Clause "New" or "Revised" License
31 stars 21 forks source link

Australia scraper tools returns bad results #339

Closed euanwm closed 2 months ago

euanwm commented 2 months ago

Describe the bug When pulling event results, the total is not checked and is pulled from the information on the event page. This means that an incorrect total on the page will be carried over into the database. The totals are manually inputted and can differ from what lifts were actually achieved.

To Reproduce Steps to reproduce the behavior:

  1. Using the AUS scraper tool, pull event ID 2170
  2. Check line 23
  3. Check total against best snatch and clean & jerk

Expected behavior Totals should be calculated based upon best lifts and NOT what total has been stated on the AUS event result page

Additional context Event result page for event ID 2170:

Scraper code:

euanwm commented 2 months ago

@joeysantia - Another one you can take if you're interested.