[RFC] possibly merge this into main sosreport tree

eucalyptus / eucalyptus-sosreport-plugins

Custom sosreport plugins for working with Eucalyptus Clouds

http://eucalyptus.com/

Other

6 stars 11 forks source link

[RFC] possibly merge this into main sosreport tree #68

Open adam-stokes opened 10 years ago

adam-stokes commented 10 years ago

Hi!

I happened to come across this branch and was curious if I could help you possibly get these plugins merged into the main sosreport tree?

Thanks Adam

hspencer77 commented 10 years ago

Hey Adam,

So sorry for the late response here. I have been away on some personal business. I would love your help here. Please let me know how you would like to proceed. Look forward to hearing from you soon.

Kind Regards,

Harold Spencer, Jr.

adam-stokes commented 10 years ago

If you're OK with it I was going to take what you have and get it in a state to be merged into the main sosreport tree and create an issue to be reviewed and merged upstream.

I also noticed that there are a couple branches that relate to older versions of sosreport, which branch should I be pulling from that you would like upstream?

bmr-cymru commented 10 years ago

Thanks for kicking this off Adam! From a quick scan it looks like there's a few easy fixes:

convert from 2.x plugin API to 3.x
Replace package-checking check_installed() methods with packages lists
Convert open coded subprocess use to plugin API calls
Move iptables-save-counters into networking plugin
Convert tmpfiles use into Archive API

The big jobs are probably going to be eucadb (can we re-use the existing postgresql support?) and eucafrontend but we can get things compatible with the current tree first and then consider those cases.

adam-stokes commented 10 years ago

The big jobs are probably going to be eucadb (can we re-use the existing postgresql support?) and eucafrontend but we can get things compatible with the current tree first and then consider those cases.

Yea im hoping we can use the existing pg plugin for eucadb

hspencer77 commented 10 years ago

Hey Adam,

Latest branch we push as an RPM is from master. With the eucadb module, we can definitely review to see if the pg plugin can be used. The main goal for the eucadb module was to keep things centralized regarding Eucalyptus specific information. However I feel that there are some improvements that can be done here. I really appreciate the review and feedback that you and bmr-cymru are providing.

Please let me know if there are any additional questions. Also, let me know what additional tasks you need me to do.

Cheers,

Harold Spencer, Jr.