Src files should use dash instead of underscore for naming convention

eucalyptus / magic-search

An AngularJS widget that provides UI for faceted and text search. "bower info angular-magic-search"

http://eucalyptus.github.io/magic-search/

Apache License 2.0

29 stars 11 forks source link

Src files should use dash instead of underscore for naming convention #15

Open ezy opened 8 years ago

ezy commented 8 years ago

Currently there's a conflict with bower where the src files aren't being automatically picked up because of the naming convention. Changing _ to - will resolve this. eg. magic_search.js => magic-search.js

ezy commented 8 years ago

I attempted to fix this but got bogged down in the subbed 'dist' folder and issues with bower versioning and grunt release. I wasn't able to bower install my forked version because the dist folder doesn't update. In the end was taking up too much time. Here's my updated repo and files if anyone wants to resolve though. https://github.com/ezy/magic-search-dist. Or let me know if I've missed something :)

dkavanagh commented 8 years ago

Thanks for this. I'll look into it and get it fixed. I've been trying to wrap up some work since I'm heading to NYC for a robotics competition tomorrow. Soonest I can work on this is Monday unless I find some time one evening.

ezy commented 8 years ago

Hey my pleasure - thanks for the awesome search functionality! I might get a bit of time to take another look at it again. Will keep my forked version updated if I do.