search

eucalyptus / magic-search

An AngularJS widget that provides UI for faceted and text search. "bower info angular-magic-search"
http://eucalyptus.github.io/magic-search/
Apache License 2.0
29 stars 11 forks source link

re-write magic-search as component, replacing events with scope bindings #19

Open dkavanagh opened 8 years ago

dkavanagh commented 8 years ago

As I've learned more about AngularJS, I though of ways I'd re-write this. While I'd like to use TypeScript and Angular 2, our product is just now moving to 1.5 and starting to use components. It seems like this re-write should make magic-search a better Angular component and prepare the code-base for Angular 2.

umens commented 7 years ago

hi @dkavanagh. I just coded the angular 2 version of this lib if you want to use it => https://github.com/umens/ngx-magicsearch

I hope it could help you.

dkavanagh commented 7 years ago

Hi Mensa, Thanks for sharing this! I'm glad to see an updated version of this. I often considered doing one that was much better than what I did before since I've learned quite a bit more about Angular since doing the original. I'm glad to see you didn't use events as that is one thing I wanted to drop in favor of bound methods (like you did). The project we use magic-search on is running Angular 1.5 now, so can't use this, but I assume many others could! I'll add a link to our readme, referencing your project.

Thanks, David

On Wed, Feb 22, 2017 at 10:08 PM, Mensa Ulysse notifications@github.com wrote:

hi @dkavanagh https://github.com/dkavanagh. I just coded the angular 2 version of this lib if you want to use it => https://github.com/umens/ngx- magicsearch

I hope it could help you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eucalyptus/magic-search/issues/19#issuecomment-281880167, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWbzoeBxXaSkFRfVzLRRIBjvXZLx3i_ks5rfPgogaJpZM4JrSJJ .

umens commented 7 years ago

There is still some improvements that can be done. And I will definitely try to do them when I will have the time. I also added a link to your project in my readme so if people want an angular 1.5 version they can use yours.