search

eucp-project / atlas

prototype result browser
https://eucp-project.github.io/atlas/
Other
3 stars 3 forks source link

Polish notebooks and data #38

Closed SarahAlidoost closed 2 years ago

SarahAlidoost commented 2 years ago

closes #40

Notebooks need raw data. The AtlasData dir available in EUCP sharepoint, has two folders: raw and preprocess. The previous data is archived in AtlasData_v0.zipand available in EUCP sharepoint, too.

The maps re-generated with these refactored codes in this branch are the same as the main branch, except for ASK to fix issue #40 and for UKCP because we got revised data.

sverhoeven commented 2 years ago

Was able to create env with environment.yml, and documented it in https://github.com/eucp-project/atlas/blob/basic_docs/python/README.md#requirements as part of PR #43

Peter9192 commented 2 years ago

Following @sverhoeven suggestion in #50, I enabled nbreview to aid in reviewing this PR: https://app.reviewnb.com/eucp-project/atlas/pull/38/

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Peter9192 commented 2 years ago

Really nice work you've done here Sarah! Somehow some of the outputs don't render in reviewNB, but they are present locally. So the IPSL/Cordex notebook is now integrated into the IPSL/REA notebook, right?

I took the liberty of pushing a commit that formats all the notebooks using black, hope that's okay.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

bvreede commented 2 years ago

Data is on zenodo and has a DOI: 10.5281/zenodo.5645154

Markdown badge: DOI [![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.5645154.svg)](https://doi.org/10.5281/zenodo.5645154)

SarahAlidoost commented 2 years ago

Really nice work you've done here Sarah! Somehow some of the outputs don't render in reviewNB, but they are present locally. So the IPSL/Cordex notebook is now integrated into the IPSL/REA notebook, right?

Right, the notebook maps_creator_IPSL_cordex is now removed. Some codes are moved to the notebook cleanup_IPSL_REA. Now the maps of cordex can be created by the python script maps_creator_atlas_data.py.

I took the liberty of pushing a commit that formats all the notebooks using black, hope that's okay.

SarahAlidoost commented 2 years ago

@SarahAlidoost Thanks for your awesome work! It even took me a while to review all the changes. That's a massive amount of work.

It is nice to see that now even the cordex files are preprocessed and grouped as independent files. This looks cleaner to the user and makes the whole workflow generic. Thanks again for the polishing. I think it is ready for merging.

Thanks for reviewing.