add modal component to display data sets information in detail

eucp-project / data-catalogue

EUCP data portal

https://eucp-project.github.io/data-catalogue/

Other

1 stars 0 forks source link

add modal component to display data sets information in detail #20

Closed geek-yang closed 2 years ago

geek-yang commented 2 years ago

Redesign the topical page
Make flashcards display less information
Add a modal component to host the detailed dataset information after clicking

geek-yang commented 2 years ago

Hi @Peter9192 , the click-and-pop-up function has been implemented, but I'm not sure about the design (especially for the flashcard/topical page, maybe a preview image just like storyboards?). Could you please take a look and leave your remark? Then we will see if there is anything need to be changed.

Peter9192 commented 2 years ago

Let me know if it's ready again for review @geek-yang

geek-yang commented 2 years ago

Let me know if it's ready again for review @geek-yang

@Peter9192 It is ready for review. Just add some changes.

geek-yang commented 2 years ago

Awesome! I have a few small suggestions. Additionally, can escape also be used to close the modal?

Feel free to merge after implementing suggestions

Good idea! Now the Escape key can used to close the modal.