search

eucp-project / data-catalogue

EUCP data portal
https://eucp-project.github.io/data-catalogue/
Other
1 stars 0 forks source link

Fix sonarcloud code quality check #54

Closed geek-yang closed 2 years ago

geek-yang commented 2 years ago

Sonarcloud is complaining about the duplication of codes.

The duplication is due to the temporal solution related to the display of maps in cpm page. The problem is will be handled when implementing new dropdown multiple select feature and the re-arrangement of tabs.

geek-yang commented 2 years ago

Hi @bvreede and @Peter9192 , based on our discussion in the morning, I made this issue. I suggest we first try the new dropdown multiple select plugin, combine the "past performance" and "future change" tab, move/remove "Analyse" tab and then see if this issue still exists or not.