Closed bvreede closed 2 years ago
Thanks for the feedback @Peter9192! I have made the requested changes, as well as an additional tweak to the image cards: the entire card is now clickable, and I have added a grayscale hover to the card.
Because the entire card is now one link, I have removed the grayscale hover on the header text, and the small loss is that the hover color of the card header background is less nice (used to be light gray, now it's very dark, almost black). I like it a bit less, but having different things happen on different hover locations is confusing, so I left it at this.
This looks much better. I noticed two more things, could you pick up on those in follow-up PRs?
- The (home) page now scrolls instead of scaling down. I would like it if at least the main page doesn't need scrollbars
- The topical cards are spaced very far apart on a (very) wide screen. A different alignment option might be nicer.
Made #63 for the second issue, thanks! Good point, I'll see if I can address this properly when I'm working on a larger screen :)
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
This pull request updates:
prose