search

eucp-project / storyboards

Simple web application to show example use cases with some interactivity. (visitors via old url will be redirected to the website with new url)
https://eucp-project.github.io/storyboards
Other
6 stars 5 forks source link

Update marjanne story #42

Closed SarahAlidoost closed 2 years ago

SarahAlidoost commented 2 years ago

The new version of powerpoint is Deltares_Marjanne_vesrion2 on sharepoint.

SarahAlidoost commented 2 years ago

@geek-yang I noticed that the size of the card of this story is smaller than others on the home page (main branch), please see here. any ideas why?

geek-yang commented 2 years ago

@geek-yang I noticed that the size of the card of this story is smaller than others on the home page (main branch), please see here. any ideas why?

@SarahAlidoost I think this is because the style of the card is defined to follow the maximum width of the figure. In this case the ratio (let's say, height/width) is large, therefore it looks smaller. I think we can save this figure with some margin, just like intro

SarahAlidoost commented 2 years ago

@geek-yang I noticed that the size of the card of this story is smaller than others on the home page (main branch), please see here. any ideas why?

@SarahAlidoost I think this is because the style of the card is defined to follow the maximum width of the figure. In this case the ratio (let's say, height/width) is large, therefore it looks smaller. I think we can save this figure with some margin, just like intro

@geek-yang thanks for reviewing and addressing the issue. Resizing the figure worked. :+1: See my last commit.

Peter9192 commented 2 years ago

I think this is because the style of the card is defined to follow the maximum width of the figure

That's correct. An alternative solution would be to fix the width of the cards. I wasn't sure when I first chose this. If the variability would have been larger, I think flexibility would be better. But now that they're almost equal size but not quite, I agree that it would make sense to try and make them equal.

Peter9192 commented 2 years ago

Also: the storyboard could still use some extra text. Particularly, this sentence should still be changed: "Html clickable model performance 131 stations -> interactive is nice​"