search

eucuepo / vagrant-kafka

Vagrant config to setup a partitioned Apache Kafka installation with clustered Apache Zookeeper
103 stars 89 forks source link

Create .gitattributes #7

Closed caddac closed 6 years ago

caddac commented 7 years ago

Solves #5 & #6. Forces lf line endings regardless of users eof setting, guaranteeing the .sh files run properly in the vagrant vms on windows platforms that checkout crlf

imarios commented 7 years ago

@caddac awesome! Does it also solves the issue with the configuration files? Was the problem only with *.sh scripts?

caddac commented 7 years ago

Once I added this file to my fork and re-cloned I was able to follow the readme instructions exactly to get a working producer/consumer via Powershell/ssh. I think the problem is that I have git configured to checkout crlf and commit lf, but for the files put onto the vagrant vms I need lf line endings. I haven't tested it but this change shouldn't affect non-windows users.

caddac commented 7 years ago

To specifically answer your questions, vagrant is reading the configuration files, only .sh files needed lf line endings I think.

imarios commented 7 years ago

Looks good to me! @eucuepo will take a look and comment/merge

caddac commented 7 years ago

@eucuepo Any update on getting this merged?