FileWriterRoot - Githubissues

eudaq / eudaq

EUDAQ Data Acquisition Framework

GNU Lesser General Public License v3.0

29 stars 144 forks source link

FileWriterRoot #337

Open hoide opened 7 years ago

hoide commented 7 years ago

I was trying to use FileWriteRoot in the converter (v1.5.0) and found that the output ROOT file is broken (says "has no keys"): main/lib/src/FileWriterRoot.cc

Looking at the code, I think the following lines should be added.

in void FileWriterRoot::StartRun(unsigned runnumber):
```
m_ttree->AutoSave("SaveSelf");
```
and also the following line in FileWriterRoot::~FileWriterRoot()
```
m_tfile->Write();
```

Best, Hide

arummler commented 7 years ago

Please try the current v1.7-dev development branch. There were some changes in the converter.

arummler commented 7 years ago

Did you try the more recent version?

hoide commented 7 years ago

Hi,

Yes, I tried v1.7-dev and it is working. Thanks for the suggestion!

Off-topic: my personal suggestion is to use vector of variables and store the data as "event list", instead of using just single int/float and store the data as "hit list". This reduces the number of TTree::GetEntry() calls and then boosts the speed to read the file significantly. But of course this changes the data format, and users may need to change downstream codes...