search

eudev-project / eudev

Repository for eudev development
GNU General Public License v2.0
522 stars 147 forks source link

Makefile: flag -n of ln is not POSIX #194

Closed concatime closed 3 years ago

concatime commented 3 years ago

As you can see here, ln’s flag -n does not exist. When I compile eudev in a distro using sbase instead of GNU coreutils, I get:

test "/tmp/43e656512ab0043ae84a87f2290f168f913ff2ac-eudev/bin" = "/tmp/43e656512ab0043ae84a87f2290f168f913ff2ac-eudev/sbin" || \
        ln -s -n -f /tmp/43e656512ab0043ae84a87f2290f168f913ff2ac-eudev/bin/udevadm /tmp/43e656512ab0043ae84a87f2290f168f913ff2ac-eudev/sbin/udevadm
usage: ln [-f] [-L | -P | -s] target [name]
       ln [-f] [-L | -P | -s] target ... dir
gmake[5]: *** [Makefile:1207: install-exec-hook] Error 1

You can see this PR as a follow-up of https://github.com/gentoo/eudev/pull/189.

blueness commented 3 years ago

This looks good to me. I'm giving up maintenance of eudev, but I'll commit this.