search

eudev-project / eudev

Repository for eudev development
GNU General Public License v2.0
525 stars 144 forks source link

rules/50-udev-default.rules: add PTP entry for Hyper-V/Azure #218

Closed dermotbradley closed 2 years ago

dermotbradley commented 2 years ago

udev rules: add rule to create /dev/ptp_hyperv

As for the KVM case, necessary for network cards with PTP devices when running a guest on HyperV

systemd-commit: 32e868f058da8b90add00b2958c516241c532b70 Author: Luca Boccassi luca.boccassi@microsoft.com Date: Fri Feb 26 10:25:31 2021 +0000

ArsenArsen commented 2 years ago

Does this work? I don't have a hyperv system to test on currently

dermotbradley commented 2 years ago

Does this work? I don't have a hyperv system to test on currently

I don't see why it would not work - it has been present in Systemd's udev rules for almost 1 year.

I also do not have a Hyper-V system to test on but need this change as I will shortly be testing Chrony using PTP on Azure (which uses the same kernel module) - this PR is part of my preparations for doing that.

In order to test this you need to have the hv_utils kernel module loaded.

ArsenArsen commented 2 years ago

I don't see why it would not work - it has been present in Systemd's udev rules for almost 1 year.

In case some supporting code for this is missing, it could become a no-op.

If you remember, please do tell us how testing on Azure goes, if you're unable to, I can probably get Hyper-V somewhere later this week or maybe next week.

Thanks!

kaniini commented 2 years ago

In this case, it is fine to merge without testing, as it is just adding another PTP subsystem entry. All the support code is there, already.