eudev-project / eudev

Repository for eudev development
GNU General Public License v2.0
521 stars 145 forks source link

Clear sysattr cache if a null pointer is passed #255

Closed NaofumiHonda closed 1 year ago

NaofumiHonda commented 1 year ago

This solves #254

ArsenArsen commented 1 year ago

the indentation here is a mix of spaces and tabs (set tabstop to 2 to see the effect). what is it that requires this behavior? I don't see it documented in systemd

ArsenArsen commented 1 year ago

oh, just saw the context. lgtm if the indentation is fixed.

the code would likely benefit from a rebasing on top of upstream, or reforking

NaofumiHonda commented 1 year ago

Remove all tabs, but ... I don't know the way for rebasing ...

ArsenArsen commented 1 year ago

that's out of scope for this PR - don't worry. please squash the commits so that we don't have redundant commits. LGTM

bbonev commented 1 year ago

@ArsenArsen you didn't click the review, I would assume it is good for a squashed merge, right?

ArsenArsen commented 1 year ago

right