eudev-project / eudev

Repository for eudev development
GNU General Public License v2.0
529 stars 144 forks source link

udev/Makefile.am: fix wrong condition for /usr type check in install-exec-hook #286

Closed midnight-carrier closed 3 months ago

midnight-carrier commented 3 months ago

Wrong condition in install-exec-hook leads to eudev installation failure in merged /usr systems and to lack of link under /sbin in separate /usr systems.

bbonev commented 3 months ago

I believe that the check is correct.

The link is created only when bindir is not equal to sbindir. Read it like (dirs are equal) or (create a link)

What are the values of bindir and sbindir in your case? If set to /usr/bin and /usr/sbin respectively, that would not create any problem, regardless if the system is usrmerged or not.

midnight-carrier commented 3 months ago

Read it like (dirs are equal) or (create a link)

Oh i see, yeah. It is weird, but on my system, default condition leads to error. I've interpreted condition as: if dirs are equal, then link from bindir to sbin. It seems, that something wrong with my system. I'll try to figure out this by myself. Sorry for this pull request.