Page context plugin - Githubissues

eudicots / Cactus

Static site generator for designers. Uses Python and Django templates.

BSD 3-Clause "New" or "Revised" License

3.47k stars 313 forks source link

Page context plugin #141

Open jammon opened 9 years ago

jammon commented 9 years ago

Ripped parsing of page context out of Page and put it into a plugin. With tests and documentation. There are different styles of metadata, the plugin tries to guess what is appropriate. Multimarkdown style is implemented but not used. In the future the style should be up for configuration.

krallin commented 9 years ago

Hi Johannes,

Just a quick note that i'll try to take a look at this over the weekend — sorry about the delayed response here.

Cheers,

jammon commented 9 years ago

I appreciate your work for this project very much, and have learned to be patient in open source development, since I'm well aware, that there are more pressing issues in everybodies life than such a project. So take your time :)

krallin commented 9 years ago

Hey @jammon ,

I added some inline comments. Most of them are rather minor. The two major things are:

I'd rather you use preBuildPage in your tests
We need to make sure this plugin runs first

Cheers,

jammon commented 9 years ago

Thank you for in-depth comments, I agree with all of them. The plugin now has ORDER = 0. Will that be low enough?

krallin commented 9 years ago

Hey @jammon

Just a quick note that this week / the next one have / are going to be very busy on my end. I'll try to review this but I can't promise anything just yet.

Cheers,

jammon commented 9 years ago

@krallin No problem, currently I have more than enough work to do as well.