search

eudicots / Cactus

Static site generator for designers. Uses Python and Django templates.
BSD 3-Clause "New" or "Revised" License
3.46k stars 314 forks source link

improve overall build speed by caching the result of the pages() method #201

Closed chaudum closed 8 years ago

chaudum commented 8 years ago

additionally use os.walk instead of recursive fileList method

krallin commented 8 years ago

Using os.walk is straightforward and probably something we should have done all along. I'd be happy to merge it separately.

Caching the result of site.pages() is a bit of a problem, though. Currently the contract is that if you make some changes to your pages during the build process (e.g. in a plugin), they'll be picked up next time pages() is evaluated.

I think this might break cactus serve (see the discussion here in #137). It might also break some plugins that depend on the current behavior, but I think it'd make sense to make a major release to address that.

Cheers,

chaudum commented 8 years ago

Ok, that's a valid point I haven't thought about. So I will make a separate PR for os.walk then and close this one.

krallin commented 8 years ago

@chaudum I noticed you'd added some tracking of how long it takes to build the site with this change. Do you have any numbers you can share? Just curious to know how much effort we should be putting into this by looking at other real projects.

chaudum commented 8 years ago

@krallin In our website project (https://github.com/crate/crate-web) we have 207 pages which took ~15s to build before. After adding the cache it took around ~4.5s.