added --path option to command line interface

[chaudum]

so you can specify a different path to build than the current working directory

[krallin]

Thanks! This looks like a good idea and the implementation is sound.

Regarding the tests:

• I'm not a huge fan of refactoring things that are unrelated to the feature being implemented (e.g. the run_cli changes). Feel free to make a separate PR for those changes. Cleanups are welcome, but I'd rather avoid noisy commits when possible (it took me a bit of time to understand why you were making those changes, and it looks like they are only cosmetic — did I miss something?)
• I don't think we need the site_a and site_b stuff. We can just put this in a separate test and reuse self.test_dir and self.path
• I think we should test that the config file is looked up in the right place. Currently thats easy to do since there is no config file in the test skeleton, so I'll just test for a warning that the file is missing.

Rather than do a lot of back and forth I've made those changes and amended your commit directly.

It's here: https://github.com/koenbok/Cactus/commit/a177332c98208ef79fcaa0af234671c862a43adf

I've also added -d as a short argument (for "dir"), since all of our other arguments have a shorthand.

Thanks again!

[chaudum]

@krallin cool thanks!

you're right, the changes in the test setup were just cosmetics. I though they made it more clear how the tests work, since it also took me some time to distinguish between self.test_dir and self.path. however I am totally fine with leaving it as it is, because - as you said - reduces the noise in the actual change.

christian

[krallin]

I guess we could rename path to site_path in tests. Would that make things clearer?

[chaudum]

yeah think so.