Use prettified URL for blog posts.

eudicots / Cactus

Static site generator for designers. Uses Python and Django templates.

BSD 3-Clause "New" or "Revised" License

3.46k stars 314 forks source link

Use prettified URL for blog posts. #229

Closed blattms closed 8 years ago

blattms commented 8 years ago

When setting prettify_urls to True, Page.path is not the URL that the page is uploaded to but the one where the source of the page is (including a possible .html extension). Therefore this commit uses Page.final_url which does not have the bogus .html extension when using prettified URLs.

blattms commented 8 years ago

I guess the problem I had is similar to the one described in #157. Therefore I guess merging this PR closes #157

blattms commented 8 years ago

This PR closes #233

blattms commented 8 years ago

Closes #234

antons commented 8 years ago

page.path on line 84 must be also replaced with page.final_url.

blattms commented 8 years ago

@antons Nice catch. Fixed it.

Just hoping that somebody, e.g. @krallin, will somewhen merge this to master.

blattms commented 8 years ago

Thanks for merging. Great to see some momentum!