eudoxia0 / crane

An ORM for Common Lisp.
http://eudoxia.me/crane/
201 stars 19 forks source link

Sqlite migrations fixed #53

Open cage2 opened 8 years ago

cage2 commented 8 years ago

Hello,

i was unable to use crane with sqlilte, during migration database creation the library complains about an "alter table" which is not supported.

The following patch try to fix that, it worked for me but i am unsure if this is a general solution (sorry for that, but i can not tests with other dbms).

Bye! C.

PS: i found the unit test failed: fixed some; i will try to address the others ASAP.

PPS: Looks like all tests passed! :)

cage2 commented 8 years ago

Hello!

Any chance considering this patch for merging with the master branch? I understand that you are rewriting the whole library but I am using this in production and would be nice, in the meantime, if I could use the upstream version instead of tracking changes in my patched one. Not considering this patch could be an improvement for sqlite backend.

Any feedback is appreciated.

Bye! C.