search

eudoxia0 / lucerne

A web framework for Common Lisp, built on Clack
http://borretti.me/lucerne/
142 stars 19 forks source link

Please move to Clack v2 and Lack #22

Open fukamachi opened 7 years ago

fukamachi commented 7 years ago

I'm going to delete clack-v1-compat in the near future at https://github.com/fukamachi/clack/pull/141.

The reason is that I found a failed test in clack-v1-compat, and I couldn't find easy way to fix it. v2 is now fairy stable and I don't feel it's reasonable to maintain the both code base.

Please consider to switching to Clack v2 and Lack.

krrrcks commented 7 years ago

Is Lucerne going to Clack v2? Are there any plans to do so? (I am not sure what has to be done for that.)

defunkydrummer commented 7 years ago

@krrrcks, if i get some extra spare time, i'll see what I can do to update lucerne.

krrrcks commented 7 years ago

That would be great. I am not familiar with the underlying Clack things. But if you need somebody to help testing etc. please hit me up!

defunkydrummer commented 7 years ago

Hi @krrrcks, and also @eudoxia0

I just tried the following: I removed the "clack-v1-compat" package [which is the package to be deleted in the future and, as far as i understand, it redefines some clackv2 functions -- @fukamachi knows better than me in this] from the list of dependencies of "lucerne", then compiled lucerne again.

Then I ran the tests and Lucerne passed all its tests.

Perhaps you can try doing the same and restarting your application to see if it works OK.

Regards, Flavio.

PS: This is a short version of the log of what i did -- the compiler / tests / output:

ASDF> (find-system "lucerne")

<SYSTEM "lucerne">

ASDF> (system-depends-on (find-system "lucerne")) ("clack" "clack-v1-compat" "myway" "cl-annot" "trivial-types" "clack-errors" "djula" "log4cl" "alexandria" "cl-mustache" "local-time") ASDF> (clear-system "lucerne") T

After this, i deleted the clack-v1-compact required dependency from the lucerne.asd file. Result:

ASDF> (system-depends-on (find-system "lucerne")) ("clack" "myway" "cl-annot" "trivial-types" "clack-errors" "djula" "log4cl" "alexandria" "cl-mustache" "local-time") ASDF> (load-system "lucerne")

; compiling file "c:/Users/fegoavil010/Documents/instalados/lisp-portacle/portacle/all/quicklisp/local-projects/lucerne/src/app.lisp" (written 30 JAN 2016 05:31:28 AM): (...) ; compilation finished in 0:00:00.043 T ASDF> (test-system "lucerne") (...) ; compilation unit finished ; caught 14 STYLE-WARNING conditions T ASDF> (in-package :lucerne-test )

<PACKAGE "LUCERNE-TEST">

LUCERNE-TEST> (run-tests )

Running test suite BASIC Running test DEFINE-ROUTES (...) Hunchentoot server is started. Listening on localhost:4545. ... (...) Did 28 checks. Pass: 28 (100%) Skip: 0 ( 0%) Fail: 0 ( 0%)

T NIL

Just to make sure... i asked ASDF again which were the dependencies of Lucerne...

LUCERNE-TEST> (in-package :asdf)

<PACKAGE "ASDF/INTERFACE">

ASDF> (system-depends-on (find-system "lucerne")) ("clack" "myway" "cl-annot" "trivial-types" "clack-errors" "djula" "log4cl" "alexandria" "cl-mustache" "local-time") ASDF>

No clack-v1-compat.