Make `npm test` run the linter as well

eugef / node-mocks-http

Mock 'http' objects for testing Express,js, Next.js and Koa routing functions

Other

761 stars 135 forks source link

Make `npm test` run the linter as well #124

Closed fidian closed 7 years ago

fidian commented 7 years ago

Combine linting with the tests so contributors have to work less and hopefully things will be merged faster. :-)

fidian commented 7 years ago

How far back in node versions do you want to support? The build is broken because of 0.x not supporting const, which is used in the updated gulp-eslint module.

howardabrams commented 7 years ago

Very nice idea and nice clean up. Thanks.

I don't really know how far back we should support things... especially since people could depend on an early/working version of this module if they wanted.