search

eugef / node-mocks-http

Mock 'http' objects for testing Express,js, Next.js and Koa routing functions
Other
761 stars 135 forks source link

add some feature #154

Closed cpd0101 closed 6 years ago

howardabrams commented 6 years ago

Thank you for the feature. Could you add some unit tests that verify these new functions? I would love to have the tests as part of the same PR. Thank you.

eugef commented 6 years ago

@cpd0101 are you still interested in writing some tests for this feature?

LoneRifle commented 6 years ago

I've just forked @cpd0101 's repo; I'll try to make time to flesh out the unit tests (and perhaps some documentation) and submit a PR to supersede this one in due course.

LoneRifle commented 6 years ago

PRs filed - 1 against @cpd0101's branch so that this can have tests, ~and 1 against master in case the tests do not get merged.~

eugef commented 6 years ago

LGTM, @howardabrams what do you think?