Better typings - Githubissues

eugef / node-mocks-http

Mock 'http' objects for testing Express routing functions

Other

753 stars 133 forks source link

Closed xaralis closed 6 years ago

xaralis commented 6 years ago

Hello,

this pull requests includes better typings which are more permissive to end user. It covers following scenarios:

request object for a controller fn which is typed as extension of express.Request
same for Response
custom properties appended to request object
fixed missing _getRenderView method on Response

eugef commented 6 years ago

@xaralis thanks for your PR

xaralis commented 6 years ago

@eugef Will you draft out a new release with these changes? It's backwards compatible so it should be totally safe. I would appreciate it.

eugef commented 6 years ago

Sure, i 'll ask @howardabrams to do it asap

howardabrams commented 6 years ago

Done! Thanks a lot!