search

eugef / node-mocks-http

Mock 'http' objects for testing Express routing functions
Other
753 stars 133 forks source link

_read() is not implemented #174

Closed rmullan closed 5 years ago

rmullan commented 5 years ago

https://github.com/howardabrams/node-mocks-http/pull/169

Uses Readable directly. This leaves it without a _read() method and breaks req.on(). I believe Readable is meant to be subclassed and _read() implemented - https://node.readthedocs.io/en/stable/api/stream/

eugef commented 5 years ago

I reverted that PR because it causes this issue