feat: add convenience method _getJSONData

eugef / node-mocks-http

Mock 'http' objects for testing Express routing functions

Other

753 stars 133 forks source link

feat: add convenience method _getJSONData #181

Closed austince closed 5 years ago

austince commented 5 years ago

Thanks for the lib! How would you feel about a small method to parse returned data as JSON? Would cut down on some common duplicate code we have. If you like the idea, I'll add some examples to the README / tests as well.

howardabrams commented 5 years ago

Looks like a good idea, so yeah, let's flesh out the feature. Thanks for the suggestion.

austince commented 5 years ago

Added:

a test case
ts defs
example files
README examples

Let me know if there's anywhere else that needs to be updated.

austince commented 5 years ago

Hey @howardabrams, do you have any time to give this a peek? Thanks!

austince commented 5 years ago

What is the release process like @howardabrams? Should I bump the version and create a PR?

eugef commented 5 years ago

I can publish a new release tomorrow.

On Tue, 30 Apr 2019, 18:36 Austin Cawley-Edwards, notifications@github.com wrote:

What is the release process like @howardabrams https://github.com/howardabrams? Should I bump the version and create a PR?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/howardabrams/node-mocks-http/pull/181#issuecomment-488001459, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG2QX3NQN4NKEZLANNVTRDPTBRPBANCNFSM4HGA5AEA .

howardabrams commented 5 years ago

I got 'er done. Thanks for your patience, @austince, see v 1.7.4

Noticed that we really need to update our package dependency tree ... may have to do another release.