Feature/add define getters

eugef / node-mocks-http

Mock 'http' objects for testing Express routing functions

Other

753 stars 133 forks source link

Feature/add define getters #189

Closed AndyOGo closed 4 years ago

AndyOGo commented 5 years ago

fixes #133 - only .xhr, all other getters have dependencies upon the Express App, or res instance, node's Request interface or other npm modules.

Not sure how it's desired to go here?

eugef commented 5 years ago

@AndyOGo sorry for the late response.

Do you still want this PR to be merged?

AndyOGo commented 5 years ago

@eugef Originally yes, though meanwhile I found that you provide these whole express-dedicated utils: https://github.com/howardabrams/node-mocks-http/tree/master/lib/express

All I thought is missing seems to be there.

eugef commented 4 years ago

Ok, then i am closing this PR