search

eugef / node-mocks-http

Mock 'http' objects for testing Express routing functions
Other
753 stars 133 forks source link

Copy all types from IncomingHeaders #192

Closed chmac closed 5 years ago

chmac commented 5 years ago

This is a completely copy of the full IncomingHeaders type defined here https://github.com/DefinitelyTyped/DefinitelyTyped/blob/e9e404ac8e23dcafd02f57db02915d848c4454b3/types/node/http.d.ts#L9-L64

I'll submit a second PR in a second which adds a shorter but compatible type so you could merge that one if you prefer. I would recommend this PR thought as it seems to be the most accurate.

eugef commented 5 years ago

Thanks for the PR @chmac I would merge this PR as it gives better type hints

chmac commented 4 years ago

@eugef Awesome, thanks for merging. Any timeline on when this will show up on NPM?

michaelknoch commented 4 years ago

@eugef can you publish a new version on npm? Would love to consume these changes form @chmac

eugef commented 4 years ago

@chmac @michaelknoch i will release asap today or tomorrow

eugef commented 4 years ago

new version 1.8.0 is out