search

eugef / node-mocks-http

Mock 'http' objects for testing Express,js, Next.js and Koa routing functions
Other
755 stars 134 forks source link

@types/express 3.17.15 -> Request/Response mismatch #266

Closed Hourglasser23 closed 1 year ago

Hourglasser23 commented 1 year ago

@types/express upgrade to latest 3.17.15 would be appreciated as types mismatch (current 3.17.7 to 3.17.15) is creating following error

Error: Argument of type 'MockRequest<Request<ParamsDictionary, any, any, ParsedQs>>' is not assignable to parameter of type 'Request<ParamsDictionary, any, any, ParsedQs, Record<string, any>>'. Types of property 'app' are incompatible. Type 'Application' is not assignable to type 'Application<Record<string, any>>'.

Hourglasser23 commented 1 year ago

I wanted to create pull request but I do not have permissions to publish branch

eugef commented 1 year ago

Hi @Hourglasser23 you can fork this repo and then create a PR.

Hourglasser23 commented 1 year ago

Hi @Hourglasser23 you can fork this repo and then create a PR.

Oh, my brain is washed with New Year 🤯 PR created, thanks @eugef 🙏🏻

eugef commented 1 year ago

No problem :) thanks for your contribution

github-actions[bot] commented 1 year ago

Stale issue message