search

eugef / node-mocks-http

Mock 'http' objects for testing Express,js, Next.js and Koa routing functions
Other
755 stars 134 forks source link

@types/express should be a non-dev dependency #289

Closed jfirebaugh closed 9 months ago

jfirebaugh commented 9 months ago

@types/express is a devDependency: https://github.com/eugef/node-mocks-http/blob/236d9020b254f67a30e3e2ae5d643678f0a546a6/package.json#L62

However, its types are imported in lib/http-mock.d.ts, which forms part of the public API: https://github.com/eugef/node-mocks-http/blob/236d9020b254f67a30e3e2ae5d643678f0a546a6/lib/http-mock.d.ts#L1

Therefore the dependency on @types/express should be a normal dependency, not a devDependency.

eugef commented 9 months ago

Hi @jfirebaugh thanks for reporting an issue.

The fix was released in version 1.14.1