search

eugene-eeo / mailthon

elegant email sending for Python
http://mailthon.readthedocs.org/en/latest/
MIT License
197 stars 19 forks source link

Unicode headers #13

Closed eugene-eeo closed 9 years ago

eugene-eeo commented 9 years ago

The UnicodeDict allows headers to be specified in Unicode or byte-strings, and perform the conversion accordingly. Also, Headers.sender and receivers now return unicode addresses. The decision being that it is easier for subclasses to extend from and also makes it easier for the mail_from address to be specified, and also lets encoding to be done where it is required.

cc @rslinckx

rslinckx commented 9 years ago

Nice !

eugene-eeo commented 9 years ago

@rslinckx do you want to make the tests nicer? They're really ugly at the moment.

rslinckx commented 9 years ago

Why ? What should be improved ?

eugene-eeo commented 9 years ago

The tests for the UnicodeDict class; currently I find them very inelegant. Also the tests for the Postman class has room for improvement.

rslinckx commented 9 years ago

I won't have time to look at this this week to be honest, so don't hold your breath :)