search

eugene-eeo / tinyrecord

transaction support for TinyDB
MIT License
94 stars 11 forks source link

Design Feedback #1

Closed eugene-eeo closed 8 years ago

eugene-eeo commented 9 years ago

@msiemens take a look at line 52. Do you think that this is the way to go as far as ensuring that only one thread modifies a single database/table at once?

msiemens commented 9 years ago

Looks fine. I'd just suggest to add a small note why WeakKeyDictionary is used so people don't have to look it up on the Python docs when reading the source code.