Closed fex80 closed 4 years ago
Hi @fex80
looks like it is a bug, I'll try to fix it asap.
Looks like an incompatibility between this package and the latest version of jest. I get coverage when I use version 24.9.0 of jest
@rmclaughlin-nelnet you are 100% right... why didn't I check it at the beginning? :man_facepalming: I had hard times 3 days ago trying to figure out what was going on :)
I'll update the dependencies and publish a new version.
Ok, I have just published a new version 1.1.1
which contains the latest jest dependencies. The code coverage should work properly now.
Thank you, @rmclaughlin-nelnet!
Hey, wanted to let you know I just had some tests break while using the latest update your package. I've pinned my version to 1.1.0 and everything went back to normal but at 1.1.1 I get this output:
TypeError: this._config.extraGlobals is not iterable
at Runtime.constructInjectedModuleParameters (node_modules/jest-runner-groups/node_modules/jest-runtime/build/index.js:1426:23)
Just a suggestion, you may want to make jest a peer dependency, or a dev dependency in your package, then users can choose their own version of jest. You also wont have to update your package every time a new version of jest is released. You could do something like
"peerDependencies": { "jest": ">= 24.9.0" }
Hm... @jwmcconnell which version of jest do you have in your package.json?
24.9.0
Ok, that's because jest-runner-groups
uses jest-runner@^25.1.0
which doesn't work properly with jest before version 25.0.0. Even don't know what to do now. One option is to publish jest-runner-groups with version 24.9.0
which works with jest 24.9.0
and version 25.1.0
which works with jest 25.1.0
. Another option is to publish jest-runner-groups
v1.1.2 with peerDependencies that declares the minimum version of jest supported by this runner. :thinking:
Hey, wanted to let you know we upgraded our jest to version 25.1.0 so everything is working with 1.1.1 of your package on our end.
Until the release version of Jest is 25 I cant use 1.1.1, (I use ts-jest which isn't compatible with 25 yet, it opens a whole can of worms), so I am stuck at 1.1.0
Ok, i have just released the new version: 2.0.1 - it declares jest-runner
and jest-docblock
as peer dependencies. So, it should work with jest@24.9.0 and higher now. Closing this thread.
Hey, thanks for making this great package! I just tried it out and it works great --- but my console coverage stats are not working correctly when I use jest-runner-groups.
Here's my output when before using the "groups" runner:
After I add
runner: "groups",
to my jest.config, the output is like this:I love the group runner, but I don't want to loose my instant feedback on coverage.
This is my jest config.
and this the relevant part from the package.json:
Is this by design, or can I set it up in a different way to keep my stats visible? Thanks!