search

eugeneie / googletest

Automatically exported from code.google.com/p/googletest
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Correct the description of GTEST_CREATE_SHARED_LIBRARY in README. #315

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The wording in the README file on 
GTEST_CREATE_SGHARED_LIBRARY/GTEST_LINKED_AS_SHARED_LIBRARY macros implies they 
are also used on non-Windows platforms. We should fix that.

Original issue reported on code.google.com by vladlosev on 23 Sep 2010 at 7:27

GoogleCodeExporter commented 9 years ago

Original comment by w...@google.com on 27 Sep 2010 at 6:20

GoogleCodeExporter commented 9 years ago 
The intention *is* that these macros are used on any platform that supports 
shared libraries.  Are they not working on non-Windows?

Original comment by w...@google.com on 27 Sep 2010 at 6:26

GoogleCodeExporter commented 9 years ago 
They are coded only for Windows.

Original comment by vladlosev on 27 Sep 2010 at 7:24

GoogleCodeExporter commented 9 years ago 
That does not matter.  We want people to *always* use these macros when using 
gtest as a shared library, even though they are not technically required today 
when using GCC.  The fact that you don't need them for GCC is an implementation 
artifact - it may well change in a future release.

I'll clarify this in README.

Original comment by w...@google.com on 27 Sep 2010 at 8:53

GoogleCodeExporter commented 9 years ago

Original comment by w...@google.com on 27 Sep 2010 at 8:53

GoogleCodeExporter commented 9 years ago

Original comment by w...@google.com on 28 Sep 2010 at 4:50

GoogleCodeExporter commented 9 years ago 
Fixed in r488.

Original comment by w...@google.com on 28 Sep 2010 at 9:29