eugenekryukov / jskit

JavaScriptCore based script engine for Delphi and CrossVcl
Mozilla Public License 2.0
76 stars 22 forks source link

ConsoleJS.exe demo crashes on launch #2

Closed felipedaragon closed 3 years ago

felipedaragon commented 7 years ago

I'm getting a crash when launching the demo (binary compiled to Redist\Win32). I'm going to investigate this further now.

felipedaragon commented 7 years ago

It is crashing with "The memory could not be read". Tried on two different Win7 Ultimate machines

czhower commented 6 years ago

JSK.API.pas change line 465 to this: if (JSLib <> 0) and (TempFiles <> nil) and (TempFiles.Count > 0) then

There are better fixes, but this one gets the job done.

czhower commented 6 years ago

Sorry this one occurs when you close the app, probably not the same issue.

felipedaragon commented 3 years ago

@czhower nope. you were right. I got really surprised when I saw the DLLs in resources being extracted to temp directory... this is very non-standard and should have been disabled by default in JSK.Config.inc through some commented out DEFINE.