search

eugenemel / maven

Maven GUI: Metabolomics Analysis and Visualization Engine
https://github.com/eugenemel/maven/releases
GNU General Public License v3.0
19 stars 9 forks source link

mzUtils::correlation function too generous #102

Open PMSeitzer opened 4 years ago

PMSeitzer commented 4 years ago

mzUtils::correlation() appears to be returning too good of a score. The values do not agree with Pearson, Spearman, or Kendall correlation coefficients implemented in R. This is probably a bug, and will have downstream effects, for example on mzDeltas in mass_spec and in the maven GUI (peak picking, peak clustering , etc).

PMSeitzer commented 4 years ago

If nothing else, it would be good to add some comments to the code (for example, what type of correlation is being computed?)

PMSeitzer commented 1 year ago

Sometimes the score is > 1. This is starting to affect other applications, such as SEC Proteomics.